source-postgres-batch: Add /_meta/row_id and /_meta/op
#2450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willdonnelly
force-pushed
the
wgd/batch-postgres-row-id-20250224
branch
from
60f5377 to
18da326
Compare
This commit adds the properties `/_meta/row_id` and `/_meta/op` to the document metadata for this capture. The Row ID property will be present on all documents going forward and will count up from zero at the start of an initial backfill (that is, a polling cycle with no prior cursor state to resume from). (As a special case, preexisting captures will also count up from zero starting with the first polling cycle after this change goes live. This should be fine, as preexisting captures also can't be using the Row ID already). Currently the `/_meta/op` property will only be set on bindings whose output collection uses `/_meta/row_id` as the key. When the collection key is the row ID, a create/update event type can be inferred for each document captured and deletions can be inferred whenever a full-refresh binding receives fewer rows in the latest polling cycle compared to the previous one.
When true, keyless tables will be discovered with collection key `[/_meta/row_id]` instead of the old fallback `[polled, index]`.
Includes a test which explicitly sets `keyless_row_id` to on and off for a keyless full-refresh table in order to demonstrate the difference in behavior.
willdonnelly
force-pushed
the
wgd/batch-postgres-row-id-20250224
branch
from
18da326 to
24808e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR implements #2382 for
source-postgres-batch:/_meta/row_idand/_meta/opproperties to all documents, plus logic to fill them out as appropriate.keyless_row_idwhich when set causes tables without a PK in the source DB to be discovered with collection key[/_meta/row_id]instead of the old[/_meta/polled, /_meta/index]behavior.row_idand it's a full-refresh binding.keyless_row_idfeature flag.Notes:
/_meta/indexis usually untouched, and only tests which run a capture in parallel with DB writes now perform that sanitization (since the breakdown of changes into polling intervals isn't consistent for those tests but is for any others). This causes a bunch of test snapshot churn, but it makes it slightly easier to verify correct operation.This change is