Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-stripe-native: handle another 404 for missing child resources #2448

Merged
merged 1 commit into from
Feb 25, 2025
Merged

source-stripe-native: handle another 404 for missing child resources #2448

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion source-stripe-native/source_stripe_native/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@
MAX_PAGE_LIMIT = 100

MISSING_RESOURCE_REGEX = r"resource_missing.+No such.+"
MISSING_LINE_ITEMS_FOR_CHECKOUT_SESSION_REGEX = r"Could not find line items for this Checkout Session. They may be missing for old testmode Checkout Sessions."
MISSING_RESOURCE_REGEXES = [MISSING_RESOURCE_REGEX, MISSING_LINE_ITEMS_FOR_CHECKOUT_SESSION_REGEX]
NOT_ON_LEGACY_BILLING_REGEX = r"Cannot list usage record summaries for.+because it is not on the legacy metered billing system"
DO_NOT_HAVE_PLATFORM_CONTROLS_REGEX = r"You cannot perform this request as you do not have Platform Controls for the Stripe Dashboard on the account"

Expand Down Expand Up @@ -364,7 +366,10 @@ async def _capture_substreams(
# It's possible for us to process events for deleted parent resources, making
# the requests for the associated child resources fail. Stripe returns a 404
# error & a message containing "resource_missing" and "No such" when this happens.
if err.code == 404 and bool(re.search(MISSING_RESOURCE_REGEX, err.message, re.DOTALL)):
if err.code == 404 and any(
re.search(regex, err.message, re.DOTALL)
for regex in MISSING_RESOURCE_REGEXES
):
log.warning(
f"Missing resource error for URL {child_url}. Skipping to the next resource.",
{
Expand Down
Loading