Skip to content

Commit

Permalink
source-sqlserver: Make 'read_only' the default
Browse files Browse the repository at this point in the history
This commit just flips the default setting for the `read_only`
feature flag so that any new captures without `no_read_only` set
will operate in watermark-less mode.
  • Loading branch information
willdonnelly committed Feb 19, 2025
1 parent 6e360aa commit 31f1901
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions source-sqlserver/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,8 @@ var featureFlagDefaults = map[string]bool{
"uppercase_discovery_queries": false,

// When true, the capture will use a fence mechanism based on observing CDC worker runs
// and LSN positions rather than watermark writes. This mechanism may require additional
// permissions, so the plan is to flip this to default-true for new users first and then
// see if we can migrate existing captures to read-only operation.
"read_only": false,
// and LSN positions rather than the old watermark write mechanism.
"read_only": true,
}

// Config tells the connector how to connect to and interact with the source database.
Expand Down

0 comments on commit 31f1901

Please sign in to comment.