From 271aa16377e3230a2071dc04032b4b8db3c6bac4 Mon Sep 17 00:00:00 2001 From: Will Donnelly Date: Wed, 19 Feb 2025 14:55:02 -0600 Subject: [PATCH] source-sqlserver: Watermarks config is deprecated Changes the wording of the watermarks table advanced config property to tell users that it's deprecated for new captures. --- source-sqlserver/.snapshots/TestGeneric-SpecResponse | 10 +++++----- source-sqlserver/main.go | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/source-sqlserver/.snapshots/TestGeneric-SpecResponse b/source-sqlserver/.snapshots/TestGeneric-SpecResponse index bf5f54d2bd..d559604f83 100644 --- a/source-sqlserver/.snapshots/TestGeneric-SpecResponse +++ b/source-sqlserver/.snapshots/TestGeneric-SpecResponse @@ -42,11 +42,6 @@ }, "advanced": { "properties": { - "watermarksTable": { - "type": "string", - "description": "The name of the table used for watermark writes during backfills. Must be fully-qualified in '\u003cschema\u003e.\u003ctable\u003e' form.", - "default": "dbo.flow_watermarks" - }, "skip_backfills": { "type": "string", "title": "Skip Backfills", @@ -84,6 +79,11 @@ "type": "string", "title": "Feature Flags", "description": "This property is intended for Estuary internal use. You should only modify this field as directed by Estuary support." + }, + "watermarksTable": { + "type": "string", + "description": "This property is deprecated for new captures as they will no longer use watermark writes by default. The name of the table used for watermark writes during backfills. Must be fully-qualified in '\u003cschema\u003e.\u003ctable\u003e' form.", + "default": "dbo.flow_watermarks" } }, "additionalProperties": false, diff --git a/source-sqlserver/main.go b/source-sqlserver/main.go index c425b67baa..2b790441ea 100644 --- a/source-sqlserver/main.go +++ b/source-sqlserver/main.go @@ -63,7 +63,6 @@ type Config struct { } type advancedConfig struct { - WatermarksTable string `json:"watermarksTable,omitempty" jsonschema:"default=dbo.flow_watermarks,description=The name of the table used for watermark writes during backfills. Must be fully-qualified in '.' form."` SkipBackfills string `json:"skip_backfills,omitempty" jsonschema:"title=Skip Backfills,description=A comma-separated list of fully-qualified table names which should not be backfilled."` BackfillChunkSize int `json:"backfill_chunk_size,omitempty" jsonschema:"title=Backfill Chunk Size,default=50000,description=The number of rows which should be fetched from the database in a single backfill query."` AutomaticChangeTableCleanup bool `json:"change_table_cleanup,omitempty" jsonschema:"title=Automatic Change Table Cleanup,default=false,description=When set the connector will delete CDC change table entries as soon as they are persisted into Flow. Requires DBO permissions to use."` @@ -71,6 +70,7 @@ type advancedConfig struct { Filegroup string `json:"filegroup,omitempty" jsonschema:"title=CDC Instance Filegroup,description=When set the connector will create new CDC instances with the specified 'filegroup_name' argument. Has no effect if CDC instances are managed manually."` RoleName string `json:"role_name,omitempty" jsonschema:"title=CDC Instance Access Role,description=When set the connector will create new CDC instances with the specified 'role_name' argument as the gating role. When unset the capture user name is used as the 'role_name' instead. Has no effect if CDC instances are managed manually."` FeatureFlags string `json:"feature_flags,omitempty" jsonschema:"title=Feature Flags,description=This property is intended for Estuary internal use. You should only modify this field as directed by Estuary support."` + WatermarksTable string `json:"watermarksTable,omitempty" jsonschema:"default=dbo.flow_watermarks,description=This property is deprecated for new captures as they will no longer use watermark writes by default. The name of the table used for watermark writes during backfills. Must be fully-qualified in '.
' form."` } type tunnelConfig struct {