esp32c6: svd: add patch for SLC peripheral #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmsyn
force-pushed
the
esp32c6/svd-slc
branch
from
07bb8ff to
c1ab1e6
Compare
Adds a SVD patch entry for the SLC register set to configure the SDIO peripheral. Adjusts the base address of the SLCHOST register set to its correct offset.
Generates the `slc` peripheral using the definitions added to the SVD patches file.
rmsyn
force-pushed
the
esp32c6/svd-slc
branch
from
c1ab1e6 to
c69e3cc
Compare
jessebraham
approved these changes
Feb 24, 2025
I was very careful to ensure the fields were correct when transferring from the spec, but having more eyes on it is always good. The generated code is definitely a lot, but the patch additions are relatively more contained (940 LoC of YAML). A lot of that is repeated, with some opportunity to further reduce by using Thank you for reviewing and merging the changes. Please feel free to ping me on any issues related to these changes, or the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a SVD patch entry for the SLC peripheral to configure SDIO.
Adjusts the base address of the SLCHOST peripheral to its correct offset.
TODO
Resolves: #320