Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RMT fix filter threshold max value #3192

Merged
merged 5 commits into from
Mar 5, 2025

Conversation

enelson1001
Copy link
Contributor

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • My changes were added to the CHANGELOG.md in the proper section.
  • I have added necessary changes to user code to the Migration Guide.
  • My changes are in accordance to the esp-rs API guidelines

Extra:

Pull Request Details 📖

Description

Please provide a clear and concise description of your changes, including the motivation behind these changes. The context is crucial for the reviewers.

Testing

Describe how you tested your changes.

@enelson1001
Copy link
Contributor Author

Well shoot that was disappointing.

  1. Change log - Which section do I add - RMT: Fix filter threshold , remove check (RMT fix filter threshold max value #3192)
  2. I see now that I just need to remove the check on the value of the filter threshold. But not sure why this didn't get picked up when I ran cargo build -- release and cargo clippy?

@Dominaezzz
Copy link
Collaborator

  1. Change log - Which section do I add - RMT: Fix filter threshold

Either Changed or Fixed.
The reason I'm not insisting on Fixed is because you could argue this wasn't a bug, it was just a limitation.

@enelson1001
Copy link
Contributor Author

enelson1001 commented Mar 1, 2025

I think something must be wrong with esp32h2 tests?

Copy link
Collaborator

@Dominaezzz Dominaezzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've spot checked the TRMs of the S2,S3,C6 and H2. (The rest are probably the same)

Fixes #3183

@enelson1001
Copy link
Contributor Author

I have printed out the RMT section of the TRM for ESP32, ESP32-S2, ESP32-S3, ESP32-C3, ESP32-C6, ESP32-H2 but couldn't find TRM for ESP32-C2. So I did check these implementations. But thank you for also looking.

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@MabezDev MabezDev added this pull request to the merge queue Mar 5, 2025
Merged via the queue into esp-rs:main with commit be7794b Mar 5, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants