Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UART: Make the tx_fifo_count and is_tx_idle UART functions public #2887

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MikeGstefan
Copy link

@MikeGstefan MikeGstefan commented Jan 4, 2025

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • My changes were added to the CHANGELOG.md in the proper section.
  • I have added necessary changes to user code to the Migration Guide.
  • My changes are in accordance to the esp-rs API guidelines

Extra:

Pull Request Details 📖

Description

Marked the fn is_tx_idle(&self) and fn tx_fifo_count(&self) as public as my project requires access to these functions.

Testing

Compilation was successful and all examples execute

@Dominaezzz
Copy link
Collaborator

Dominaezzz commented Jan 4, 2025

The names could use some improving before going public imo

At least remove tx from the names.

@MabezDev
Copy link
Member

Marked the fn is_tx_idle(&self) and fn tx_fifo_count(&self) as public as my project requires access to these functions.

Would you mind explaining a bit about your use case and why these need to be exposed?

@MikeGstefan
Copy link
Author

Would you mind explaining a bit about your use case and why these need to be exposed?

My board has external drivers with additional inputs that need to be manually controlled. The state of these pins is dependent on the uart buffer state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants