Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo #127

Merged
merged 1 commit into from
Feb 17, 2025
Merged

Fix typo #127

merged 1 commit into from
Feb 17, 2025

Conversation

bugadani
Copy link
Contributor

No description provided.

@bugadani bugadani added the skip-changelog No changelog modification needed label Feb 17, 2025
bjoernQ
bjoernQ approved these changes Feb 17, 2025
View reviewed changes
Copy link
Collaborator

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bjoernQ bjoernQ added this pull request to the merge queue Feb 17, 2025
Merged via the queue into main with commit d23f1d4 Feb 17, 2025
11 checks passed
@bugadani bugadani deleted the typo branch February 17, 2025 18:17
@SergioGasquez
Copy link
Member

This fixes #125, I had the exact same typo, linked the lines of esp-generate with the typo on the issue and couldn't spot it 😓

@SergioGasquez SergioGasquez mentioned this pull request Feb 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoernQ bjoernQ bjoernQ approved these changes

Assignees
No one assigned
Labels
skip-changelog No changelog modification needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bugadani @SergioGasquez @bjoernQ