Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make application stop to be a request in the application controller #9558

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

TheGeorge
Copy link
Contributor

Application start is already a request, and this change make stop one as well. This ensures
that the application controller isn't blocked during application shutdown.

Copy link
Contributor

github-actions bot commented Mar 7, 2025

CT Test Results

    2 files     70 suites   1h 9m 31s ⏱️
1 569 tests 1 326 ✅ 241 💤 2 ❌
1 820 runs  1 526 ✅ 292 💤 2 ❌

For more details on these failures, see this check.

Results for commit 619fb5c.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@michalmuskala
Copy link
Contributor

I think we need to track stopping applications (and the stopper processes) properly to avoid the same issue as in #9494.
In particular, during termination, if an application started stopping, we should wait until it finishes before we stop any of its dependencies. I think this PR as implemented could violate that, since we don't track the stopping applications in terminate

@TheGeorge
Copy link
Contributor Author

The change currently keeps only track of stopping applications, but not the stopper. Semantically, there is currently no change to the status quo when using the API from the application module.

From the application controller point of view, when it comes to stopping, there is no dependency between applications, and they can be stopped independently right now. (regardless of the PR)

@TheGeorge
Copy link
Contributor Author

I ran the failing test suite and test locally, but cannot reproduce the failure.

@garazdawi
Copy link
Contributor

I've retriggered the tests to see if the error persists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team:VM Assigned to OTP team VM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants