Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsonrpc: Gas estimate to optimize for max contract gas used #13913

Merged
merged 6 commits into from
Feb 22, 2025
Merged

jsonrpc: Gas estimate to optimize for max contract gas used #13913

merged 6 commits into from
Feb 22, 2025
+33 −42

Conversation

somnathb1
Copy link
Contributor

No description provided.

@somnathb1
Copy link
Contributor Author

Tested with the following results

Tests
Txn Estimate Actual limit Actual usage
https://gnosisscan.io/tx/0x234b91d897a14e97e56906acb6c211e9400beeaa43d86792857893094fb3cdd8
 1M 2M 780K
https://gnosisscan.io/tx/0xcc66653386ed41daee3ad59eca4ac776f248e92afbe65749d5e153eaef3fc239
 72K 66K 53K
https://gnosisscan.io/tx/0x71c0718c2e1795848bc704ab2f3ae5a702c7a1425433145e28b32cf1ee2d3463
 133K 133K 130K
https://gnosisscan.io/tx/0xbd6548497180f93636d8448663b68196b56e2b6a29bf1a84681ade3a772fb174
 160K 500K 160K
https://gnosisscan.io/tx/0xd7a6e830e7e0aa0b591b7d56d825cb71d18ab0e132d32ad82ad5357cd26fb5a8
 87K 520K 86K
https://gnosisscan.io/tx/0xbeae7b94e6e656f6b3e51c9bfbef82f9181f8aeadcbdec81751570790333d40d
 21k 21k 21k
https://gnosisscan.io/tx/0x7d42ca7abd86dab2693e7f2f7399505ffd75c9374dc68cf8bf2e960d62431066
 531k 584k 530k
https://gnosisscan.io/tx/0x4d8e1ffbdf98bed8d848793980050d4ee27ea3728af9738599bfd149dd53e4ff
 187k 262k 185k
https://gnosisscan.io/tx/0xe1d699db060bf6e5ea3e40e702353d8b9be08e2df5bef50ece0a25be1b7301b7
 1.5M 1.89M 1.19M





@somnathb1 somnathb1 linked an issue Feb 22, 2025 that may be closed by this pull request
eth_estimateGas underestimates tx with function that catches reverts #13636
Closed
@Giulio2002
Copy link
Contributor

lint is failing + please, once merged cherry-pick it to release/3.0

@somnathb1 somnathb1 merged commit 31971b8 into main Feb 22, 2025
13 checks passed
@somnathb1 somnathb1 deleted the som/new_gas_estimate branch February 22, 2025 21:49
somnathb1 added a commit that referenced this pull request Feb 23, 2025
@somnathb1
jsonrpc: Gas estimate to optimize for max contract gas used (#13913)
b945553
@somnathb1 somnathb1 mentioned this pull request Feb 23, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Giulio2002 Giulio2002 Giulio2002 approved these changes

@lupin012 lupin012 Awaiting requested review from lupin012

@yperbasis yperbasis Awaiting requested review from yperbasis

@AskAlexSharov AskAlexSharov Awaiting requested review from AskAlexSharov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

eth_estimateGas underestimates tx with function that catches reverts
2 participants
@somnathb1 @Giulio2002