Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download memory issue #2640

Merged
merged 24 commits into from
Jan 24, 2025
Merged

Download memory issue #2640

merged 24 commits into from
Jan 24, 2025

Conversation

robertbasti
Copy link
Collaborator

Fixes

This pull request fixes #2617

Description

prevent downloading time logs which exceeds memory limit

Type of change

  • Bugfix
  • New feature (non-breaking change which adds functionality)
  • Enhancement of existing functionality
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Impacted Areas in Application

  • Frontend
  • API
  • WITSML
  • Desktop
  • Other (please describe)

Checklist:

Communication

  • I have made corresponding changes to the documentation
  • PR affects application security

Code quality

  • I have self-reviewed my code
  • No new warnings are generated

Test coverage

  • New code is covered by passing tests

Further comments

eliasbruvik
eliasbruvik requested changes Jan 22, 2025
View reviewed changes
Src/WitsmlExplorer.Frontend/components/Modals/DownloadOptionsSelectionModal.tsx Show resolved Hide resolved
Src/WitsmlExplorer.Frontend/components/Modals/DownloadOptionsSelectionModal.tsx Show resolved Hide resolved
Src/WitsmlExplorer.Frontend/components/Modals/DownloadOptionsSelectionModal.tsx Show resolved Hide resolved
Src/WitsmlExplorer.Frontend/components/Modals/DownloadOptionsSelectionModal.tsx Show resolved Hide resolved
Src/WitsmlExplorer.Frontend/components/Modals/DownloadOptionsSelectionModal.tsx Outdated Show resolved Hide resolved
Src/WitsmlExplorer.Frontend/components/Modals/DownloadOptionsSelectionModal.tsx Outdated Show resolved Hide resolved
Src/WitsmlExplorer.Frontend/components/Modals/DownloadOptionsSelectionModal.tsx Outdated Show resolved Hide resolved
Src/WitsmlExplorer.Frontend/components/Modals/DownloadOptionsSelectionModal.tsx Show resolved Hide resolved
eliasbruvik
eliasbruvik approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@eliasbruvik eliasbruvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer checklist

  • Read issue and PR
  • Pulled branch and manually tested
  • Verify that PR resolves issue
  • Reviewed the code

@robertbasti robertbasti merged commit eec1e51 into equinor:main Jan 24, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliasbruvik eliasbruvik eliasbruvik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Large log data download - Memory issue🐛
2 participants
@robertbasti @eliasbruvik