Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX-2208 DeleteEmptyMnemonics - Delete curves without min or max index #2209

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

eliasbruvik
Copy link
Contributor

@eliasbruvik eliasbruvik commented Jan 17, 2024

Fixes

This pull request fixes #2208

Description

I could not find any cases where a curve with data does not return min or max indexes. Deleting the curves without these indexes should hopefully be safe.

Type of change

  • Bugfix
  • New feature (non-breaking change which adds functionality)
  • Enhancement of existing functionality
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Impacted Areas in Application

  • Frontend
  • API
  • WITSML
  • Other (please describe)

Checklist:

Communication

  • I have made corresponding changes to the documentation
  • PR affects application security

Code quality

  • I have self-reviewed my code
  • No new warnings are generated

Test coverage

  • New code is covered by passing tests

Further comments

Copy link
Contributor

@janmarius janmarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer checklist

  • Read issue and PR
  • Pulled branch and manually tested
  • Verify that PR resolves issue
  • Reviewed the code

@eliasbruvik eliasbruvik merged commit 64a4a26 into equinor:main Jan 18, 2024
@eliasbruvik eliasbruvik deleted the FIX-2208 branch January 18, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeleteEmptyMnemonics does not work on some servers🐛
2 participants