Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX-2145 change max_line_length to 80 characters #2146

Closed

Conversation

janmarius
Copy link
Contributor

Fixes

This pull request fixes #2145

Description

In order to maintain consistency and readability across all frontend files, it is recommended to format files using Prettier's printWidth feature, which is set to 80 characters. This will ensure that the code is easy to understand and follow, and will also make it easier for other developers to collaborate on the project.

The reason why Prettier recommends a printWidth of 80 characters is to ensure readability.

Type of change

  • Bugfix
  • New feature (non-breaking change which adds functionality)
  • Enhancement of existing functionality
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Impacted Areas in Application

  • Frontend
  • API
  • WITSML
  • Other (please describe)

Checklist:

Communication

  • I have made corresponding changes to the documentation
  • PR affects application security

Code quality

  • I have self-reviewed my code
  • No new warnings are generated

Test coverage

  • New code is covered by passing tests

@janmarius janmarius marked this pull request as draft November 28, 2023 12:37
@janmarius janmarius closed this Nov 28, 2023
@janmarius janmarius deleted the FIX-2145-frontend-code-formatting branch November 28, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve code formatting and linting👉
1 participant