Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX-2142 ToWitsml method on API ObjectOnWellbore models #2143

Merged
merged 5 commits into from
Nov 30, 2023

Conversation

eliasbruvik
Copy link
Contributor

@eliasbruvik eliasbruvik commented Nov 27, 2023

Fixes

This pull request fixes #2142

Description

Added a ToWitsml method for API models that extends ObjectOnWellbore.
Had to fix properties of some models that were wrong/missing.
I did not yet make all conversions use the new method. This could be done in another issue, or by gradually changing while refactoring or working on other features.

Type of change

  • Bugfix
  • New feature (non-breaking change which adds functionality)
  • Enhancement of existing functionality
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Impacted Areas in Application

  • Frontend
  • API
  • WITSML
  • Other (please describe)

Checklist:

Communication

  • I have made corresponding changes to the documentation
  • PR affects application security

Code quality

  • I have self-reviewed my code
  • No new warnings are generated

Test coverage

  • New code is covered by passing tests

Further comments

Copy link
Contributor

@janmarius janmarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job!
Reviewer checklist

  • Read issue and PR
  • Pulled branch and manually tested
  • Verify that PR resolves issue
  • Reviewed the code

@eliasbruvik eliasbruvik merged commit 6dd2243 into equinor:main Nov 30, 2023
2 checks passed
@eliasbruvik eliasbruvik deleted the FIX-2142-toWitsml branch November 30, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ToWitsml method on API ObjectOnWellbore models
2 participants