Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: Stop using XTGeoDialog for logging #138

Merged
merged 1 commit into from
Sep 18, 2024
Merged

MAINT: Stop using XTGeoDialog for logging #138

merged 1 commit into from
Sep 18, 2024

Conversation

tnatt
Copy link
Contributor

@tnatt tnatt commented Sep 18, 2024

Remove the use of XTGeoDialog for logging functionality. Closes #135

mferrera
mferrera approved these changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@mferrera mferrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice job. I see there are some changes in the levels (i.e. info vs debug) but I am in agreement with them

@tnatt
Copy link
Contributor Author

tnatt commented Sep 18, 2024

👍 Nice job. I see there are some changes in the levels (i.e. info vs debug) but I am in agreement with them

Yes, It seemed the xtg.say was used mostly for printing info messages to the user, and the logger.info was used for debugging by the developer... so I changed to logger.debug for those 👍

@tnatt tnatt merged commit 0add100 into equinor:main Sep 18, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mferrera mferrera mferrera approved these changes

@jcrivenaes jcrivenaes Awaiting requested review from jcrivenaes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't use XTGeoDialog for logging
2 participants
@tnatt @mferrera