-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
20 add option to trigger owl validation on load #29
Merged
agarciadom
merged 25 commits into
main
from
20-add-option-to-trigger-owl-validation-on-load
Feb 13, 2025
Merged
20 add option to trigger owl validation on load #29
agarciadom
merged 25 commits into
main
from
20-add-option-to-trigger-owl-validation-on-load
Feb 13, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agarciadom
reviewed
Feb 10, 2025
bundles/org.eclipse.epsilon.emc.rdf/src/org/eclipse/epsilon/emc/rdf/RDFModel.java
Outdated
Show resolved
Hide resolved
agarciadom
reviewed
Feb 10, 2025
...psilon.emc.rdf.dt.tests/src/org/eclipse/epsilon/emc/rdf/dt/tests/EclipseRDFModelUrlTest.java
Outdated
Show resolved
Hide resolved
agarciadom
reviewed
Feb 10, 2025
...rg.eclipse.epsilon.emc.rdf.tests/src/org/eclipse/epsilon/emc/rdf/RDFModelValidationTest.java
Outdated
Show resolved
Hide resolved
agarciadom
reviewed
Feb 10, 2025
...rg.eclipse.epsilon.emc.rdf.tests/src/org/eclipse/epsilon/emc/rdf/RDFModelValidationTest.java
Show resolved
Hide resolved
agarciadom
reviewed
Feb 10, 2025
...rg.eclipse.epsilon.emc.rdf.tests/src/org/eclipse/epsilon/emc/rdf/RDFModelValidationTest.java
Outdated
Show resolved
Hide resolved
agarciadom
reviewed
Feb 10, 2025
...rg.eclipse.epsilon.emc.rdf.tests/src/org/eclipse/epsilon/emc/rdf/RDFModelValidationTest.java
Outdated
Show resolved
Hide resolved
The fact that an option is the default in the model is separate than it's Jena-based or not. We should use separate constants to represent named values and to represent the default choice.
agarciadom
reviewed
Feb 10, 2025
...lipse.epsilon.emc.rdf.dt/src/org/eclipse/epsilon/emc/rdf/dt/RDFModelConfigurationDialog.java
Outdated
Show resolved
Hide resolved
agarciadom
reviewed
Feb 10, 2025
...psilon.emc.rdf.dt.tests/src/org/eclipse/epsilon/emc/rdf/dt/tests/EclipseRDFModelUrlTest.java
Outdated
Show resolved
Hide resolved
...lipse.epsilon.emc.rdf.tests/src/org/eclipse/epsilon/emc/rdf/MOF2RDFModelOWLReasonerTest.java
Outdated
Show resolved
Hide resolved
...g.eclipse.epsilon.emc.rdf.tests/src/org/eclipse/epsilon/emc/rdf/RDFModelOWLReasonerTest.java
Outdated
Show resolved
Hide resolved
The PR needs a bit more work before it can be merged. Specifically, I can't review RDFModel as there are too many changes which are unrelated to the main point of the PR. Please avoid making sweeping changes to a class unless the PR is specifically about it. |
agarciadom
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Housekeeping RDFModel
I added some comments to identify the sections/components more clearly.
RDFModel
RDFModelConfigurationDialog
There is only a check box for validation (on/off), this turns Jena's validation process on/off. Failing the Validation throws an exception which stops the loading process. In the future there may be a need for one or more validation processes a text box will replace the boolean check box, so a list (CSV) of validations can be given.
RDFModel
The existing method for validation could be replaced or overridden in future revisions to enable more complex validation techniques.
Test
Added a new test file for testing validation. One test checks that the validation error message contains some expected string for the invalid OWL Data Model. The second test validates a corrected version of the OWL Data Model.
[Last revision] Change the internal property representation for validation to a text string, which can be used for a wider scope of validation processes.