Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20 add option to trigger owl validation on load #29

Merged
merged 25 commits into from
Feb 13, 2025

Conversation

OwenR-York
Copy link
Contributor

Housekeeping RDFModel

  • Collected the property variables/methods together
    I added some comments to identify the sections/components more clearly.

RDFModel

  • Add validation property (boolean) to RDFModel -- default on (true)
  • Add accessor/mutator for the validation property
  • Add property loading process for validation

RDFModelConfigurationDialog

  • Add UI element (check box) to set the validation of models on load
  • Add validation property storing process
  • Add validation property recall process

There is only a check box for validation (on/off), this turns Jena's validation process on/off. Failing the Validation throws an exception which stops the loading process. In the future there may be a need for one or more validation processes a text box will replace the boolean check box, so a list (CSV) of validations can be given.

RDFModel

  • Add validation method
  • Capture validation errors with an EolModelLoadingException
  • Insert validation method call into the load process

The existing method for validation could be replaced or overridden in future revisions to enable more complex validation techniques.

Test

  • Add test to the OWLDemoData that runs validation to detect issues with MaxCardinality.

Added a new test file for testing validation. One test checks that the validation error message contains some expected string for the invalid OWL Data Model. The second test validates a corrected version of the OWL Data Model.

[Last revision] Change the internal property representation for validation to a text string, which can be used for a wider scope of validation processes.

  • Change the property handling (internally) from boolean/string to only strings

@OwenR-York OwenR-York linked an issue Feb 7, 2025 that may be closed by this pull request
The fact that an option is the default in the model is separate than
it's Jena-based or not. We should use separate constants to represent
named values and to represent the default choice.
@agarciadom
Copy link
Member

The PR needs a bit more work before it can be merged. Specifically, I can't review RDFModel as there are too many changes which are unrelated to the main point of the PR. Please avoid making sweeping changes to a class unless the PR is specifically about it.

@agarciadom agarciadom merged commit 8635167 into main Feb 13, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to trigger OWL validation on load
2 participants