Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storage): Fix storage connector error #1547

Merged
merged 17 commits into from
May 30, 2024
Merged

fix(storage): Fix storage connector error #1547

merged 17 commits into from
May 30, 2024

Conversation

FOkvj
Copy link
Contributor

@FOkvj FOkvj commented May 20, 2024

Description

Close 1546

Checklist:

  • My code follows the style guidelines of this project
  • I have already rebased the commits and make the commit message conform to the project standard.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

@FOkvj FOkvj closed this May 20, 2024
@FOkvj FOkvj reopened this May 20, 2024
@Aries-ckt
Copy link
Collaborator

Thanks for your contribution, will test soon.

@fangyinc
Copy link
Collaborator

@fanzhidongyzby Please review it.

Aries-ckt
Aries-ckt previously approved these changes May 21, 2024
View reviewed changes
Copy link
Collaborator

@Aries-ckt Aries-ckt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@Aries-ckt Aries-ckt mentioned this pull request May 30, 2024
Closed
15 tasks
Aries-ckt
Aries-ckt previously approved these changes May 30, 2024
View reviewed changes
Copy link
Collaborator

@Aries-ckt Aries-ckt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@fangyinc fangyinc changed the title Fix storage connector fix(storage): storage connector May 30, 2024
@github-actions github-actions bot added the fix Bug fixes label May 30, 2024
@fangyinc fangyinc changed the title fix(storage): storage connector fix(storage): Fix storage connector error May 30, 2024
fangyinc
fangyinc approved these changes May 30, 2024
View reviewed changes
Copy link
Collaborator

@fangyinc fangyinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Aries-ckt
Aries-ckt approved these changes May 30, 2024
View reviewed changes
Copy link
Collaborator

@Aries-ckt Aries-ckt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@Aries-ckt Aries-ckt merged commit 04703f2 into eosphoros-ai:main May 30, 2024
4 checks passed
fanzhidongyzby
fanzhidongyzby reviewed May 31, 2024
View reviewed changes
examples/rag/graph_rag_example.py
@@ -6,6 +6,7 @@
from dbgpt.rag import ChunkParameters
from dbgpt.rag.assembler import EmbeddingAssembler
from dbgpt.rag.knowledge import KnowledgeFactory
from dbgpt.storage.knowledge_graph.knowledge_graph import BuiltinKnowledgeGraphConfig
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused import

Hopshine pushed a commit to Hopshine/DB-GPT that referenced this pull request Sep 10, 2024
@FOkvj @Aries-ckt @Hopshine
fix(storage): Fix storage connector error (eosphoros-ai#1547)
c11acd1 
Co-authored-by: dong <dongzhancai@iie2.com>
Co-authored-by: Zhancai Dong <dongzhancai1@jd.com>
Co-authored-by: aries_ckt <916701291@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fanzhidongyzby fanzhidongyzby fanzhidongyzby left review comments

@Aries-ckt Aries-ckt Aries-ckt approved these changes

@fangyinc fangyinc fangyinc approved these changes

Assignees
No one assigned
Labels
fix Bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] [storage] wrong config in VectorStoreConnector
4 participants
@FOkvj @Aries-ckt @fangyinc @fanzhidongyzby