Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updates outdated Rust dynamic_modules README #38405

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

mathetake
Copy link
Member

Commit Message: docs: updates outdated Rust dynamic_modules README
Additional Description:
Risk Level: n/a
Testing: n/a
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Copy link

Docs for this Pull Request will be rendered here:

https://storage.googleapis.com/envoy-pr/38405/docs/index.html

The docs are (re-)rendered each time the CI envoy-presubmit (precheck docs) job completes.

🐱

Caused by: #38405 was opened by mathetake.

see: more, trace.

Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #38405 was opened by mathetake.

see: more, trace.

Comment on lines -9 to -14

[dev-dependencies.envoy-proxy-dynamic-modules-rust-sdk]
git = "https://github.com/envoyproxy/envoy"
tag = "vX.Y.Z"
# Enable testing features to use the mock Envoy objects.
features = ["testing"]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a garbage left during the iteration in a previous PR - no longer valid

@mathetake mathetake marked this pull request as ready for review February 11, 2025 18:40
@mathetake
Copy link
Member Author

cc @phlax

Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @mathetake

@phlax phlax enabled auto-merge (squash) February 11, 2025 18:44
@phlax phlax merged commit 60b645b into envoyproxy:main Feb 11, 2025
24 checks passed
@mathetake mathetake deleted the readmeupdate branch February 11, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants