Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make admission_control exception free #38308

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

mathetake
Copy link
Member

Commit Message: Make admission_control exception free
Additional Description:
Risk Level: low
Testing: existing ones
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #38308 was opened by mathetake.

see: more, trace.

@mathetake
Copy link
Member Author

/retest

@mathetake mathetake marked this pull request as ready for review February 4, 2025 21:39
@mathetake
Copy link
Member Author

/assign @alyssawilk

Copy link
Contributor

@alyssawilk alyssawilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for continued clean up!

@alyssawilk alyssawilk merged commit 71b50fa into envoyproxy:main Feb 5, 2025
24 checks passed
@mathetake mathetake deleted the exceptionadmission branch February 5, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants