Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes stale tools/clang_tools directory #38292

Merged
merged 3 commits into from
Feb 3, 2025

Conversation

mathetake
Copy link
Member

@mathetake mathetake commented Feb 3, 2025

No description provided.

Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #38292 was opened by mathetake.

see: more, trace.

@mathetake
Copy link
Member Author

cc @phlax

@mathetake mathetake changed the title Removes stale tools/clang_toole directory Removes stale tools/clang_tools directory Feb 3, 2025
@mathetake mathetake closed this Feb 3, 2025
@mathetake mathetake reopened this Feb 3, 2025
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Feb 3, 2025
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @phlax

🐱

Caused by: #38292 was synchronize by mathetake.

see: more, trace.

@mathetake mathetake marked this pull request as ready for review February 3, 2025 16:55
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
@mathetake
Copy link
Member Author

what? mobile?

@mathetake
Copy link
Member Author

/retest

Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the cleanup @mathetake

as discussed offline it seems unlikely that anyone is still using this - if it turns out that is wrong we can revisit

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Feb 3, 2025
@phlax phlax merged commit 8d74209 into envoyproxy:main Feb 3, 2025
25 checks passed
@mathetake mathetake deleted the nolongermaintainedinvalid branch February 4, 2025 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants