Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates exception allowed files #38290

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Updates exception allowed files #38290

merged 1 commit into from
Feb 3, 2025

Conversation

mathetake
Copy link
Member

@mathetake mathetake commented Feb 2, 2025 •
edited
Loading

This removes a couple of files no longer having exceptions
from config.yaml.

@mathetake
Updates exception allowed files
d93231e 
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
@repokitteh-read-only RepoKitteh - Read Only
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #38290 was opened by mathetake.

see: more, trace.

@mathetake mathetake marked this pull request as ready for review February 2, 2025 18:15
@mathetake
Copy link
Member Author

cc @phlax

@mathetake
Copy link
Member Author

damn unicode stuff

@mathetake
Copy link
Member Author

/retest

adisuissa
adisuissa approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@adisuissa adisuissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@adisuissa adisuissa merged commit c5c81c1 into envoyproxy:main Feb 3, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisuissa adisuissa adisuissa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathetake @adisuissa