Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error updating listener (via ADS) using additional_addresses #37373

Closed
bbassingthwaite opened this issue Nov 26, 2024 · 6 comments · May be fixed by #37396
Closed

Error updating listener (via ADS) using additional_addresses #37373

bbassingthwaite opened this issue Nov 26, 2024 · 6 comments · May be fixed by #37396
Assignees
Labels
bug stale stalebot believes this issue/PR has not been touched recently

Comments

@bbassingthwaite
Copy link
Contributor

Title: Error updating listener (via ADS) using additional_addresses

Description:

Updating a listener via ADS and adding/removing additional_addresses will cause Envoy to reject via an error: error adding listener: '<REDACTED>' has duplicate address '10.36.50.235:50054,10.36.50.235:443,10.36.50.235:50055' as existing listener

Repro steps:

  • Add a dynamic listener via ADS/LDS that uses a TCP address and has 1 or more additional_addresses. In this example, we will have 10.36.50.235:80,10.36.50.235:50055 as additional_addresses
  • Update the dynamic listener but change the additional_addresses to 10.36.50.235:443,10.36.50.235:50055. This will cause the duplicate address error to be provoked.

It seems that adding and removing in a single update isn't working. In the above example, adding 443 and removing 80 isn't working. But adding a new additional_addresses OR removing an additional_addresses in a single update is currently working. So I could add 443 and then remove 80 in two separate updates.

@bbassingthwaite bbassingthwaite added bug triage Issue requires triage labels Nov 26, 2024
bbassingthwaite added a commit to bbassingthwaite/envoy that referenced this issue Nov 28, 2024
…nd removal of an additional_address in the same update.

Fixes envoyproxy#37373

Signed-off-by: Braden Bassingthwaite <bbassingthwaite@digitalocean.com>
bbassingthwaite added a commit to bbassingthwaite/envoy that referenced this issue Nov 28, 2024
…nd removal of an additional_address in the same update.

Fixes envoyproxy#37373

Signed-off-by: Braden Bassingthwaite <bbassingthwaite@digitalocean.com>
bbassingthwaite added a commit to bbassingthwaite/envoy that referenced this issue Nov 28, 2024
…nd removal of an additional_address in the same update.

Fixes envoyproxy#37373

Signed-off-by: Braden Bassingthwaite <bbassingthwaite@digitalocean.com>
bbassingthwaite added a commit to bbassingthwaite/envoy that referenced this issue Nov 28, 2024
…nd removal of an additional_address in the same update.

Fixes envoyproxy#37373

Signed-off-by: Braden Bassingthwaite <bbassingthwaite@digitalocean.com>
bbassingthwaite added a commit to bbassingthwaite/envoy that referenced this issue Nov 28, 2024
…nd removal of an additional_address in the same update.

Fixes envoyproxy#37373

Signed-off-by: Braden Bassingthwaite <bbassingthwaite@digitalocean.com>
bbassingthwaite added a commit to bbassingthwaite/envoy that referenced this issue Nov 28, 2024
…nd removal of an additional_address in the same update.

Fixes envoyproxy#37373

Signed-off-by: Braden Bassingthwaite <bbassingthwaite@digitalocean.com>
bbassingthwaite added a commit to bbassingthwaite/envoy that referenced this issue Nov 28, 2024
…nd removal of an additional_address in the same update.

Fixes envoyproxy#37373

Signed-off-by: Braden Bassingthwaite <bbassingthwaite@digitalocean.com>
bbassingthwaite added a commit to bbassingthwaite/envoy that referenced this issue Nov 28, 2024
…nd removal of an additional_address in the same update.

Fixes envoyproxy#37373

Signed-off-by: Braden Bassingthwaite <bbassingthwaite@digitalocean.com>
@ggreenway ggreenway removed the triage Issue requires triage label Dec 2, 2024
@wufanqqfsc
Copy link

When this PR fix can be deliver to master branch ? our team done some local test, this should be one bug. And this pr fix works well. We need this pr fix.

Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Jan 16, 2025
@bbassingthwaite
Copy link
Contributor Author

@wufanqqfsc Trying to get someone to review 🤷 but not having much luck

@github-actions github-actions bot removed the stale stalebot believes this issue/PR has not been touched recently label Jan 17, 2025
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Feb 16, 2025
Copy link

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 23, 2025
@bbassingthwaite
Copy link
Contributor Author

@ggreenway can we reopen this please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug stale stalebot believes this issue/PR has not been touched recently
Projects
None yet
3 participants