-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error updating listener (via ADS) using additional_addresses #37373
Comments
…nd removal of an additional_address in the same update. Fixes envoyproxy#37373 Signed-off-by: Braden Bassingthwaite <bbassingthwaite@digitalocean.com>
…nd removal of an additional_address in the same update. Fixes envoyproxy#37373 Signed-off-by: Braden Bassingthwaite <bbassingthwaite@digitalocean.com>
…nd removal of an additional_address in the same update. Fixes envoyproxy#37373 Signed-off-by: Braden Bassingthwaite <bbassingthwaite@digitalocean.com>
…nd removal of an additional_address in the same update. Fixes envoyproxy#37373 Signed-off-by: Braden Bassingthwaite <bbassingthwaite@digitalocean.com>
…nd removal of an additional_address in the same update. Fixes envoyproxy#37373 Signed-off-by: Braden Bassingthwaite <bbassingthwaite@digitalocean.com>
…nd removal of an additional_address in the same update. Fixes envoyproxy#37373 Signed-off-by: Braden Bassingthwaite <bbassingthwaite@digitalocean.com>
…nd removal of an additional_address in the same update. Fixes envoyproxy#37373 Signed-off-by: Braden Bassingthwaite <bbassingthwaite@digitalocean.com>
…nd removal of an additional_address in the same update. Fixes envoyproxy#37373 Signed-off-by: Braden Bassingthwaite <bbassingthwaite@digitalocean.com>
When this PR fix can be deliver to master branch ? our team done some local test, this should be one bug. And this pr fix works well. We need this pr fix. |
This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions. |
@wufanqqfsc Trying to get someone to review 🤷 but not having much luck |
This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions. |
This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions. |
@ggreenway can we reopen this please? |
Title: Error updating listener (via ADS) using additional_addresses
Description:
Updating a listener via ADS and adding/removing
additional_addresses
will cause Envoy to reject via an error:error adding listener: '<REDACTED>' has duplicate address '10.36.50.235:50054,10.36.50.235:443,10.36.50.235:50055' as existing listener
Repro steps:
additional_addresses
. In this example, we will have10.36.50.235:80,10.36.50.235:50055
asadditional_addresses
additional_addresses
to10.36.50.235:443,10.36.50.235:50055
. This will cause the duplicate address error to be provoked.It seems that adding and removing in a single update isn't working. In the above example, adding 443 and removing 80 isn't working. But adding a new
additional_addresses
OR removing anadditional_addresses
in a single update is currently working. So I could add 443 and then remove 80 in two separate updates.The text was updated successfully, but these errors were encountered: