Skip to content

Commit

Permalink
Update QUICHE from 66856e353 to 475ee6de1 (#38493)
Browse files Browse the repository at this point in the history
https://github.com/google/quiche/compare/66856e353..475ee6de1

```
$ git log 66856e353..475ee6de1 --date=short --no-merges --format="%ad %al %s"

2025-02-18 quiche-dev Enabling rolled out flags.
2025-02-18 vasilvv Allow MoQT simulator to output results in a custom format.
2025-02-18 abhisinghx Add new capsules COMPRESSION_ASSIGN and COMPRESSION_CLOSE for CONNECT-UDP-Bind to QUICHE
2025-02-18 vasilvv No public description
2025-02-18 martinduke Delete end_object from MoQT SUBSCRIBE and SUBSCRIBE_UPDATE messages.
2025-02-18 martinduke do not send DELIVERY_TIMEOUT parameter if value is infinite. Never send in MoQT FETCH or SUBSCRIBE_ANNOUNCES.
2025-02-18 martinduke Add timer to close the session after sending MoQT GOAWAY.
2025-02-17 martinduke Implement basic MoQT GoAway handling.
2025-02-16 wub Increments a counter when `QuicLinuxSocketUtils::WritePacket` receives an error with `errno=ENOBUFS`.
2025-02-13 dschinazi Deprecate quic_chaos_protector_avoid_copy
2025-02-13 dschinazi Deprecate quic_enable_chaos_protection_v2
2025-02-13 vasilvv Fix a bug in WebTransportWriteBlockedScheduler.
2025-02-13 wub No public description
2025-02-13 vasilvv Add support for delivery timeouts in the simulator.
```

Commit Message: Quiche Envoy Merge oncall
Additional Description:
Risk Level: Low
Testing: My local dev environment is broken. @asedeno is testing locally
on my behalf.
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

---------

Signed-off-by: Vanessa Reimer <vreimer@google.com>
  • Loading branch information
vanessareimer authored Feb 21, 2025
1 parent 4c77c6e commit 4ace96e
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 7 deletions.
1 change: 1 addition & 0 deletions bazel/external/quiche.BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -3014,6 +3014,7 @@ envoy_cc_library(
":quic_platform_base",
":quiche_common_buffer_allocator_lib",
":quiche_common_ip_address",
":quiche_common_socket_address",
":quiche_common_wire_serialization",
":quiche_web_transport_web_transport_lib",
],
Expand Down
6 changes: 3 additions & 3 deletions bazel/repository_locations.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -1218,12 +1218,12 @@ REPOSITORY_LOCATIONS_SPEC = dict(
project_name = "QUICHE",
project_desc = "QUICHE (QUIC, HTTP/2, Etc) is Google‘s implementation of QUIC and related protocols",
project_url = "https://github.com/google/quiche",
version = "66856e353d1bde66f1dfaf5762f03cb2a5e9a96e",
sha256 = "00c0bfeb77ca1d01b1462fe68b6d952199f109a419a1b03e88ada4730deabc9b",
version = "475ee6de17c79a8c30f6951cad8a02e58481b196",
sha256 = "5ec7213f83127be35dc7f265384f048aba4c0386f422b5d6bffc143bcaab08e5",
urls = ["https://github.com/google/quiche/archive/{version}.tar.gz"],
strip_prefix = "quiche-{version}",
use_category = ["controlplane", "dataplane_core"],
release_date = "2025-02-12",
release_date = "2025-02-19",
cpe = "N/A",
license = "BSD-3-Clause",
license_url = "https://github.com/google/quiche/blob/{version}/LICENSE",
Expand Down
8 changes: 4 additions & 4 deletions test/integration/quic_http_integration_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1337,14 +1337,14 @@ name: "envoy.tls.cert_validator.timed_cert_validator"
static_cast<Extensions::TransportSockets::Tls::TimedCertValidatorFactory*>(cert_validator_factory)
->resetForTest();
static_cast<Extensions::TransportSockets::Tls::TimedCertValidatorFactory*>(cert_validator_factory)
->setValidationTimeOutMs(std::chrono::milliseconds(1000));
->setValidationTimeOutMs(std::chrono::milliseconds(2500));
initialize();
static_cast<Extensions::TransportSockets::Tls::TimedCertValidatorFactory*>(cert_validator_factory)
->setExpectedPeerAddress(fmt::format(
"{}:{}", Network::Test::getLoopbackAddressUrlString(version_), lookupPort("http")));
// Change the handshake timeout to be 500ms to fail the handshake while the cert validation is
// pending.
quic::QuicTime::Delta connect_timeout = quic::QuicTime::Delta::FromMilliseconds(500);
quic::QuicTime::Delta connect_timeout = quic::QuicTime::Delta::FromMilliseconds(2000);
auto& persistent_info = static_cast<PersistentQuicInfoImpl&>(*quic_connection_persistent_info_);
persistent_info.quic_config_.set_max_idle_time_before_crypto_handshake(connect_timeout);
persistent_info.quic_config_.set_max_time_before_crypto_handshake(connect_timeout);
Expand Down Expand Up @@ -1378,11 +1378,11 @@ name: "envoy.tls.cert_validator.timed_cert_validator"
static_cast<Extensions::TransportSockets::Tls::TimedCertValidatorFactory*>(cert_validator_factory)
->resetForTest();
static_cast<Extensions::TransportSockets::Tls::TimedCertValidatorFactory*>(cert_validator_factory)
->setValidationTimeOutMs(std::chrono::milliseconds(1000));
->setValidationTimeOutMs(std::chrono::milliseconds(2500));
initialize();
// Change the handshake timeout to be 500ms to fail the handshake while the cert validation is
// pending.
quic::QuicTime::Delta connect_timeout = quic::QuicTime::Delta::FromMilliseconds(500);
quic::QuicTime::Delta connect_timeout = quic::QuicTime::Delta::FromMilliseconds(2000);
auto& persistent_info = static_cast<PersistentQuicInfoImpl&>(*quic_connection_persistent_info_);
persistent_info.quic_config_.set_max_idle_time_before_crypto_handshake(connect_timeout);
persistent_info.quic_config_.set_max_time_before_crypto_handshake(connect_timeout);
Expand Down

0 comments on commit 4ace96e

Please sign in to comment.