Fix access logger not erroring on failure to open file

Signed-off-by: Raven Black <ravenblack@dropbox.com>
envoyproxy · Feb 21, 2025 · 0b89b8b · 0b89b8b
1 parent ba7bf5f
commit 0b89b8b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/source/common/access_log/access_log_manager_impl.cc b/source/common/access_log/access_log_manager_impl.cc
@@ -41,7 +41,7 @@ AccessLogManagerImpl::createAccessLog(const Filesystem::FilePathAndType& file_in
   }
 
   Api::IoCallBoolResult open_result = file->open(default_flags);
-  if (!open_result.return_value_) {
+  if (!open_result.ok()) {
     return absl::InvalidArgumentError(fmt::format("unable to open file '{}': {}", file_name,
                                                   open_result.err_->getErrorDetails()));
   }

diff --git a/test/common/access_log/access_log_manager_impl_test.cc b/test/common/access_log/access_log_manager_impl_test.cc
@@ -68,7 +68,8 @@ class AccessLogManagerImplTest : public testing::Test {
 };
 
 TEST_F(AccessLogManagerImplTest, BadFile) {
-  EXPECT_CALL(*file_, open_(_)).WillOnce(Return(ByMove(Filesystem::resultFailure<bool>(false, 0))));
+  EXPECT_CALL(*file_, open_(_))
+      .WillOnce(Return(ByMove(Filesystem::resultFailure<bool>(false, -1))));
   EXPECT_FALSE(
       access_log_manager_
           .createAccessLog(Filesystem::FilePathAndType{Filesystem::DestinationType::File, "foo"})