-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: do not embed HTTPRoute as-is #47
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Krishanx92
reviewed
Dec 18, 2024
after this i finally will work on implementing the initial controller/extproc code |
Krishanx92
approved these changes
Dec 18, 2024
yuzisun
reviewed
Dec 19, 2024
yuzisun
reviewed
Dec 19, 2024
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
yuzisun
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up on #39, and stops embedding HTTPRoute as-is.
The rationale here is somewhat complicated; We have to know which
backend we route traffics to before Envoy decides the routing as
we need to do perform the transformation etc. Hence, we need to
implement the routing logics (e.g. header matching, weights, etc.)
by ourselves, and cannot rely on the native router code path in Envoy.
That results in us only being able to support only a small subset of
HTTPRoute functionality as well as we cannot simply use the embedded
HTTPRoute as a "base" in the translation. If we embed HTTPRoute here,
it would create an impression that all HTTPRoute functionality can be
supported here no matter how much we document otherwise.
We discussed about this issue, and reached the consensus that we should
have our own LLMRoute rule definition and only have the fields that
actually can be supported.
The example API would look like;