Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: local default settings file #383

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Conversation

nacx
Copy link
Contributor

@nacx nacx commented Feb 20, 2025

Commit Message

chore: local default settings file

Allows having a local .makerc file with the custom values for the make variables.

Related Issues/PRs (if applicable)

N/A

Special notes for reviewers (if applicable)

N/A

Signed-off-by: Ignasi Barrera <ignasi@tetrate.io>
@nacx nacx requested a review from a team as a code owner February 20, 2025 00:29
Copy link
Member

@mathetake mathetake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind sharing what kind of custom commands you define in there?

@mathetake mathetake merged commit e26aa5e into envoyproxy:main Feb 20, 2025
17 checks passed
@nacx
Copy link
Contributor Author

nacx commented Feb 20, 2025

Basically just defaults for my envs and stuff to push to my custom registry, flags to push to local insecure registries, etc, that I use a lot during development. Here is an example of the vars I see there so I can easily just run make docker-build.extproc and don't bother about other args.

$ cat .makerc

GOARCH_LIST = amd64

PLATFORMS = --platform linux/amd64

DOCKER_BUILD_ARGS = --push
DOCKER_BUILD_ARGS += --output=type=registry,registry.insecure=true

OCI_REGISTRY = kind-cluster-registry:6000
TAG = dev

@nacx nacx deleted the local-defaults branch February 20, 2025 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants