controller: removes sink implementation #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
mathetake
changed the title
mathetake
added a commit
that referenced
this pull request
Feb 18, 2025
**Commit Message** Previously, the mutex was not taken on the OIDC cache, but after #364, it is necessary as the sync function of each controller now might be invoked by other controllers. Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
daixiang0
pushed a commit
to daixiang0/ai-gateway
that referenced
this pull request
Feb 19, 2025
**Commit Message** This removes the config sink style implementation of controller. Previously, there the config sink was used as a central place to do the mutation that involves multiple resources. However, it unnecessarily comes with the complexity and this simplifies the implementation by removing it. Majority of the changes are code moving, especially moving the resource mutation code from sink to under AIGatewayRoute controller. This was brought up in the conversation with @sanposhiho and more follow up PRs will come to polish the implementation. --------- Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com> Signed-off-by: Loong <long0dai@foxmail.com>
daixiang0
pushed a commit
to daixiang0/ai-gateway
that referenced
this pull request
Feb 19, 2025
**Commit Message** Previously, the mutex was not taken on the OIDC cache, but after envoyproxy#364, it is necessary as the sync function of each controller now might be invoked by other controllers. Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com> Signed-off-by: Loong <long0dai@foxmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message
This removes the config sink style implementation of controller. Previously, there the config sink was used as a central place to do the mutation that involves multiple resources. However, it unnecessarily comes with the complexity and this simplifies the implementation by removing it.
Majority of the changes are code moving, especially moving the resource mutation code from sink to under AIGatewayRoute controller.
This was brought up in the conversation with @sanposhiho and more follow up PRs will come to polish the implementation.