Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: apply license headers to all source files #337

Merged
merged 3 commits into from
Feb 13, 2025

Conversation

nacx
Copy link
Contributor

@nacx nacx commented Feb 13, 2025

Commit Message

chore: apply license headers to all source files

Apply license headers to all source files, and add a check in the format make target to make sure they're not missed.

Related Issues/PRs (if applicable)

N/A

Special notes for reviewers (if applicable)

N/A

@nacx nacx requested a review from a team as a code owner February 13, 2025 15:46
@nacx nacx marked this pull request as draft February 13, 2025 15:47
@mathetake
Copy link
Member

hah you can ignore the terraform stuff or ignore .github/** directory maybe

SPDX-License-Identifier: Apache-2.0
The full text of the Apache license is available in the LICENSE file at
the root of the repo.
paths-ignore:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe .bin as well

nacx added 3 commits February 13, 2025 18:32
Signed-off-by: Ignasi Barrera <ignasi@tetrate.io>
Signed-off-by: Ignasi Barrera <ignasi@tetrate.io>
Signed-off-by: Ignasi Barrera <ignasi@tetrate.io>
# The full text of the Apache license is available in the LICENSE file at
# the root of the repo.

{{ if .Values.controller.serviceAccount.create -}}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that I've removed the leading - in the conditional; otherwise the next line was appended directly to the comment instead of having a newline

@nacx nacx marked this pull request as ready for review February 13, 2025 17:38
@nacx nacx requested a review from mathetake February 13, 2025 17:39
@mathetake mathetake merged commit 0b92c0b into envoyproxy:main Feb 13, 2025
17 checks passed
@nacx nacx deleted the license branch February 13, 2025 17:58
daixiang0 pushed a commit to daixiang0/ai-gateway that referenced this pull request Feb 19, 2025
**Commit Message**

chore: apply license headers to all source files

Apply license headers to all source files, and add a check in the
`format` make target to make sure they're not missed.

**Related Issues/PRs (if applicable)**

N/A

**Special notes for reviewers (if applicable)**

N/A

---------

Signed-off-by: Ignasi Barrera <ignasi@tetrate.io>
Signed-off-by: Loong <long0dai@foxmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants