Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: makes each credential optional #327

Merged
merged 1 commit into from
Feb 11, 2025
Merged

e2e: makes each credential optional #327

merged 1 commit into from
Feb 11, 2025

Conversation

mathetake
Copy link
Member

Commit Message

This modifies the e2e of basic usage example where some cases use credentials. Previously, if any one of them is missing, the entire test was skipped. This makes each credential optional and allows to partially run available test cases.

Related Issues/PRs (if applicable)

This is a counterpart of #326 in tests/e2e

Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
@mathetake mathetake marked this pull request as ready for review February 11, 2025 19:23
@mathetake mathetake requested a review from a team as a code owner February 11, 2025 19:23
@mathetake mathetake merged commit 3938a4b into main Feb 11, 2025
17 checks passed
@mathetake mathetake deleted the skiptestcase branch February 11, 2025 19:23
daixiang0 pushed a commit to daixiang0/ai-gateway that referenced this pull request Feb 12, 2025
**Commit Message**

This modifies the e2e of basic usage example where some cases use
credentials. Previously, if any one of them is missing, the entire test
was skipped. This makes each credential optional and allows to partially
run available test cases.

**Related Issues/PRs (if applicable)**

This is a counterpart of envoyproxy#326  in tests/e2e

Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
daixiang0 pushed a commit to daixiang0/ai-gateway that referenced this pull request Feb 12, 2025
**Commit Message**

This modifies the e2e of basic usage example where some cases use
credentials. Previously, if any one of them is missing, the entire test
was skipped. This makes each credential optional and allows to partially
run available test cases.

**Related Issues/PRs (if applicable)**

This is a counterpart of envoyproxy#326  in tests/e2e

Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
daixiang0 pushed a commit to daixiang0/ai-gateway that referenced this pull request Feb 19, 2025
**Commit Message**

This modifies the e2e of basic usage example where some cases use
credentials. Previously, if any one of them is missing, the entire test
was skipped. This makes each credential optional and allows to partially
run available test cases.

**Related Issues/PRs (if applicable)**

This is a counterpart of envoyproxy#326  in tests/e2e

Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Signed-off-by: Loong <long0dai@foxmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant