chore: fix always reinstall #321
Merged
+19
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Loong <long0dai@foxmail.com>
|
Now: |
mathetake
reviewed
Feb 11, 2025
daixiang0
added a commit
to daixiang0/ai-gateway
that referenced
this pull request
Feb 12, 2025
**Commit Message** Previously, all Go-installed tools are always installed because of the trailing spaces. This fixes Makefile.tools.mk so that we can properly cache the tools. **Related Issues/PRs (if applicable)** Fixes envoyproxy#320 --------- Signed-off-by: Loong <long0dai@foxmail.com> Co-authored-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
daixiang0
added a commit
to daixiang0/ai-gateway
that referenced
this pull request
Feb 12, 2025
**Commit Message** Previously, all Go-installed tools are always installed because of the trailing spaces. This fixes Makefile.tools.mk so that we can properly cache the tools. **Related Issues/PRs (if applicable)** Fixes envoyproxy#320 --------- Signed-off-by: Loong <long0dai@foxmail.com> Co-authored-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
daixiang0
added a commit
to daixiang0/ai-gateway
that referenced
this pull request
Feb 19, 2025
**Commit Message** Previously, all Go-installed tools are always installed because of the trailing spaces. This fixes Makefile.tools.mk so that we can properly cache the tools. **Related Issues/PRs (if applicable)** Fixes envoyproxy#320 --------- Signed-off-by: Loong <long0dai@foxmail.com> Co-authored-by: Takeshi Yoneda <t.y.mathetake@gmail.com> Signed-off-by: Loong <long0dai@foxmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message
Previously, all Go-installed tools are always installed because of the trailing spaces. This fixes Makefile.tools.mk so that we can properly cache the tools.
Related Issues/PRs (if applicable)
Fixes #320