e2e: update/fix extproc test #305
Conversation
Signed-off-by: Alexa Griffith <agriffith96@gmail.com>
Signed-off-by: Alexa Griffith <agriffith96@gmail.com>
alexagriffith
changed the title
| if tc.testCaseName == "openai" && openAIAPIKey == "" { | ||
| t.Skip("Skipping openai test case as TEST_OPENAI_API_KEY is not set") | ||
| } |
There was a problem hiding this comment.
please do not specialize openai. what happens when we are adding more providers? what about someone wanting to test openai but not aws? Can you simply add a env var requirement check and skip each case accordingly?
There was a problem hiding this comment.
what do you suggest? rn we skip all if no aws key, which makes sense, and we check openai key because its the only other one to check at the moment, if we add a new key we can check it too. can you help me understand better how it could be improved now? open to changing it
There was a problem hiding this comment.
im not sure if an env var req check would look much different than this? maybe im not understanding
|
i went ahed and implemented the generic version in #326 - hope this works for you :) |
|
I know it takes a little time, but I was def willing to update it just wanted to understand what it was you were suggesting. I understand the change though thanks! |
|
yeah sorry i just wanted to fix it by myself as in hindsight i should've made it optional in the first place so i wanted to avoid wasting your time. Thanks for your help anyways! |
**Commit Message** This makes each credential optional. **Related Issues/PRs (if applicable)** Closes envoyproxy#305 --------- Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
**Commit Message** This makes each credential optional. **Related Issues/PRs (if applicable)** Closes envoyproxy#305 --------- Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
**Commit Message** This makes each credential optional. **Related Issues/PRs (if applicable)** Closes envoyproxy#305 --------- Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com> Signed-off-by: Loong <long0dai@foxmail.com>
Commit Message
make fixes to current test file