chore: fixes CEL validation test target name #300
Merged
+18
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathetake
commented
Feb 6, 2025
| - name: Run unit tests | ||
| run: make test-coverage | ||
| - run: make test-coverage |
There was a problem hiding this comment.
note: i figured the naming for the make target doesn't provide any helpful information so i rather have the raw make command exposed - that way anyone can see what they are supposed to do locally when this and elsewhere is failing
ericmariasis
pushed a commit
to ericmariasis/ai-gateway
that referenced
this pull request
Feb 7, 2025
**Commit Message** This renames `make test-cel` to `make test-crdcel` to be precise about what it is testing since we are also using CEL for LLM costs. Also, this renames the tests/cel-validation directory to tests/crdcel since it was previously incorrect and didn't match the make target. --------- Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com> Signed-off-by: Eric Mariasis <ericmariasis829@gmail.com>
missBerg
pushed a commit
to melsal13/ai-gateway
that referenced
this pull request
Feb 9, 2025
**Commit Message** This renames `make test-cel` to `make test-crdcel` to be precise about what it is testing since we are also using CEL for LLM costs. Also, this renames the tests/cel-validation directory to tests/crdcel since it was previously incorrect and didn't match the make target. --------- Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com> Signed-off-by: Erica Hughberg <erica.sundberg.90@gmail.com>
daixiang0
pushed a commit
to daixiang0/ai-gateway
that referenced
this pull request
Feb 19, 2025
**Commit Message** This renames `make test-cel` to `make test-crdcel` to be precise about what it is testing since we are also using CEL for LLM costs. Also, this renames the tests/cel-validation directory to tests/crdcel since it was previously incorrect and didn't match the make target. --------- Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com> Signed-off-by: Loong <long0dai@foxmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message
This renames
make test-celtomake test-crdcelto be preciseabout what it is testing since we are also using CEL for LLM costs.
Also, this renames the tests/cel-validation directory to tests/crdcel
since it was previously incorrect and didn't match the make target.