extproc: eliminates context.Background in config loader #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
ericmariasis
pushed a commit
to ericmariasis/ai-gateway
that referenced
this pull request
Feb 7, 2025
**Commit Message** This eliminates context.Background in config loading code path. **Related Issues/PRs (if applicable)** This is a follow up on envoyproxy#296 Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com> Signed-off-by: Eric Mariasis <ericmariasis829@gmail.com>
missBerg
pushed a commit
to melsal13/ai-gateway
that referenced
this pull request
Feb 9, 2025
**Commit Message** This eliminates context.Background in config loading code path. **Related Issues/PRs (if applicable)** This is a follow up on envoyproxy#296 Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com> Signed-off-by: Erica Hughberg <erica.sundberg.90@gmail.com>
daixiang0
pushed a commit
to daixiang0/ai-gateway
that referenced
this pull request
Feb 19, 2025
**Commit Message** This eliminates context.Background in config loading code path. **Related Issues/PRs (if applicable)** This is a follow up on envoyproxy#296 Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com> Signed-off-by: Loong <long0dai@foxmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message
This eliminates context.Background in config loading
code path.
Related Issues/PRs (if applicable)
This is a follow up on #296