controller: refactors flags #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
mathetake
changed the title
mathetake
added a commit
that referenced
this pull request
Jan 30, 2025
**Commit Message**: This is a follow up on #235 and does the same refactoring to external processor. --------- Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
This refactors the main function of controller.
Previously it was conflated with the implementation detail
(zap) and that is exposed unnecessarily as controller main
arguments. This resolves it and expose the only necessary
one to have the consistency with extproc.
Notably, this also adds an new controller argument/helm
value that configures the log level of external processor.
More fine tuned, per-route log level can be added later
as in #204.
This also increases the test coverage.
Related Issues/PRs (if applicable):
Supersedes #204