You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of retrieving AWS credentials in newAWSHandler, could we get the AWS credentials for every request in first release and optimize it later with AssumeRoleWithWebIdentity API ?
I propose this change because we have temporary AWS credentials in the credential secrets, and we have our own token-refresher to refresh the credentials.
@yuzisun, @aabchoo and @mathetake , do you think if we can retrieve the AWS credentials for every request in first release and optimize it later with AssumeRoleWithWebIdentity API?
@yuzisun, @aabchoo and @mathetake , do you think if we can retrieve the AWS credentials for every request in first release and optimize it later with AssumeRoleWithWebIdentity API?
We can implement a secret watcher and update the credential in cache which is orthogonal to AssumeRoleWithWebIdentity, it is still a useful feature for user who rotates the aws credential manually.
yes, secret watcher is definitely the way to go and this reading-file-on-request-path is unacceptable (see #169). That's exactly what I suggested to @aabchoo in #125 : #125 (comment)
Btw you can already emulate the refreshing behavior by using a unique secret resource name in your refresher. Anyways this is exactly the opposite of whwre we should go and I don't see any reason to have this now.
**Commit Message**:
This adds a secret watcher controller that enables the
hot reload of any secret referenced by backendTrafficPolicy.
**Related Issues/PRs (if applicable)**:
Follow up on #43#106#161
Supersede #185
---------
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wengyao04
changed the title
Commit Message:
Instead of retrieving AWS credentials in
newAWSHandler, could we get the AWS credentials for every request in first release and optimize it later withAssumeRoleWithWebIdentityAPI ?I propose this change because we have temporary AWS credentials in the credential secrets, and we have our own token-refresher to refresh the credentials.
Retrieve credentials for each request
Related Issues/PRs (if applicable):
Special notes for reviewers (if applicable):