Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance PR style check to forbid markdown format links #267

Closed
mathetake opened this issue Feb 1, 2025 · 0 comments · Fixed by #322
Closed

Enhance PR style check to forbid markdown format links #267

mathetake opened this issue Feb 1, 2025 · 0 comments · Fixed by #322
Labels
ci help wanted Extra attention is needed

Comments

@mathetake
Copy link
Member

mathetake commented Feb 1, 2025 •
edited
Loading

I would like to avoid any markdown specific rendering in the commit message as per my comment here #265 (comment)

This must be a part of this workflow: https://github.com/envoyproxy/ai-gateway/blob/main/.github/workflows/pr_style_check.yaml
@mathetake mathetake changed the title Enhance PR style check to forbid [link_name](https://foo.com) Enhance PR style check to forbid markdown format links Feb 1, 2025
@mathetake mathetake added help wanted Extra attention is needed ci labels Feb 1, 2025
@daixiang0 daixiang0 mentioned this issue Feb 11, 2025
Merged
daixiang0 added a commit to daixiang0/ai-gateway that referenced this issue Feb 19, 2025
@daixiang0
chore: check markdown format link (envoyproxy#322)
3c1881e 
**Commit Message**

Use regex to check.


**Related Issues/PRs (if applicable)**


Fixes envoyproxy#267

---------

Signed-off-by: Loong <long0dai@foxmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: check markdown format link daixiang0/ai-gateway
1 participant
@mathetake