Skip to content

Commit

Permalink
ci: relaxes PR title length check (#269)
Browse files Browse the repository at this point in the history
**Commit Message**

This follows up on #266 and relaxes the PR title length 
restriction to 60 characters. It was too strict.

Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
  • Loading branch information
mathetake authored Feb 1, 2025
1 parent 59de25e commit c7d0187
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/pr_style_check.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -73,11 +73,11 @@ jobs:
env:
# Do not use ${{ github.event.pull_request.title }} directly in run command.
TITLE: ${{ github.event.pull_request.title }}
# We want to make sure that each commit "subject" is under 53 characters not to
# We want to make sure that each commit "subject" is under 60 characters not to
# be truncated in the git log as well as in the GitHub UI.
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=bc7938deaca7f474918c41a0372a410049bd4e13#n664
run: |
if (( ${#TITLE} >= 53 )); then
echo "The PR title is too long. Please keep it under 52 characters."
if (( ${#TITLE} >= 60 )); then
echo "The PR title is too long. Please keep it under 60 characters."
exit 1
fi

0 comments on commit c7d0187

Please sign in to comment.