host should be set outside translator

Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
envoyproxy · Dec 6, 2024 · 33c5c41 · 33c5c41
1 parent 86ce149
commit 33c5c41
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 9 deletions.
diff --git a/internal/extproc/translator/openai_openai.go b/internal/extproc/translator/openai_openai.go
@@ -6,7 +6,6 @@ import (
 	"fmt"
 	"log/slog"
 
-	corev3 "github.com/envoyproxy/go-control-plane/envoy/config/core/v3"
 	extprocv3http "github.com/envoyproxy/go-control-plane/envoy/extensions/filters/http/ext_proc/v3"
 	extprocv3 "github.com/envoyproxy/go-control-plane/envoy/service/ext_proc/v3"
 
@@ -47,10 +46,7 @@ func (o *openAIToOpenAITranslatorV1ChatCompletion) RequestBody(body *extprocv3.H
 			ResponseBodyMode:   extprocv3http.ProcessingMode_STREAMED,
 		}
 	}
-	headerMutation = &extprocv3.HeaderMutation{
-		SetHeaders: []*corev3.HeaderValueOption{{Header: &corev3.HeaderValue{Key: "host", Value: "api.openai.com"}}},
-	}
-	return headerMutation, nil, override, req.Model, nil
+	return nil, nil, override, req.Model, nil
 }
 
 // ResponseBody implements [Translator.ResponseBody].

diff --git a/internal/extproc/translator/openai_openai_test.go b/internal/extproc/translator/openai_openai_test.go
@@ -52,10 +52,7 @@ func TestOpenAIToOpenAITranslatorV1ChatCompletionRequestBody(t *testing.T) {
 					require.Nil(t, mode)
 				}
 
-				require.NotNil(t, hm)
-				require.Len(t, hm.SetHeaders, 1)
-				require.Equal(t, "host", hm.SetHeaders[0].Header.Key)
-				require.Equal(t, "api.openai.com", hm.SetHeaders[0].Header.Value)
+				require.Nil(t, hm)
 			})
 		}
 	})