From 0aa1d94a77a2b20af7632fee3bf0eadc1fad24f2 Mon Sep 17 00:00:00 2001 From: John Marrero Date: Mon, 22 Jan 2024 21:29:06 -0800 Subject: [PATCH] SQ-4167: fix promise handling on plugin install config call --- lib/EnvoyAPI.js | 15 +++++++-------- package-lock.json | 4 ++-- package.json | 2 +- 3 files changed, 10 insertions(+), 11 deletions(-) diff --git a/lib/EnvoyAPI.js b/lib/EnvoyAPI.js index 8692181..3600faf 100644 --- a/lib/EnvoyAPI.js +++ b/lib/EnvoyAPI.js @@ -387,15 +387,14 @@ class EnvoyAPI { * @returns {Promise<{}>} */ async getPluginInstallConfig(installId) { - return new Promise((resolve, reject) => { - this.request({ - method: 'GET', - url: `/api/v2/plugin-services/installs/${installId}/config`, - }).then(body => resolve(EnvoyAPI.getDataFromBody(body))) - .catch((error) => { - EnvoyAPI.safeRequestsError(error).catch((err) => reject(err)); - }); + const body = await this.request({ + method: 'GET', + url: `/api/v2/plugin-services/installs/${installId}/config`, + }).catch((error) => { + return EnvoyAPI.safeRequestsError(error); }); + + return EnvoyAPI.getDataFromBody(body); } /** diff --git a/package-lock.json b/package-lock.json index 77764ee..44a8ce8 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "@envoy/envoy-integrations-sdk", - "version": "1.4.1", + "version": "1.4.2", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@envoy/envoy-integrations-sdk", - "version": "1.4.1", + "version": "1.4.2", "license": "ISC", "dependencies": { "axios": "^1.4.0", diff --git a/package.json b/package.json index 2eedb6b..843086b 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@envoy/envoy-integrations-sdk", - "version": "1.4.1", + "version": "1.4.2", "description": "", "main": "index.js", "scripts": {