Enable branch = true for coverage.run

[Kludex]

The goal here is to enable branch = true on tool.coverage.run. We want to be able to cover all logic paths.

[ShreySinha02]

opened #2513

[ShreySinha02]

can not pass on --fail-under=100 but on 99 it can pass the the coverage

[Kludex]

Well, the goal is exactly to add tests...

[TechNiick]

There was already a PR open for this issue here.
I have started to work on test coverage. The first PR was opened here.
After merging this first one I will continue with the rest of them.

[hoenie-ams]

FYI @Kludex : The link doesn't work (404)

[Kludex]

FYI @Kludex : The link doesn't work (404)

We are not using polar. They don't remove the links after you remove the integration.

[lealre]

Putting the table to make it easier to identify:

Name	Branch	BrPart	Cover	Missing
starlette/_utils.py	14	1	98%	78->82
starlette/middleware/gzip.py	22	2	98%	16->22, 91->exit
starlette/requests.py	96	3	99%	114->116, 233->225, 253->278
starlette/routing.py	164	3	99%	199->202, 401->430, 484->496
TOTAL	2016	9	99%

Let me know if there is any inconsistency in it.

[Kludex]

Very few missing now:

+ venv/bin/coverage report --show-missing --skip-covered --fail-under=100
Name                           Stmts   Miss Branch BrPart  Cover   Missing
--------------------------------------------------------------------------
starlette/_utils.py               50      0     14      1    98%   78->82
starlette/middleware/gzip.py      82      0     22      2    98%   16->22, 91->exit
starlette/requests.py            201      0     96      3    99%   114->116, 233->225, 253->278
starlette/routing.py             471      0    164      3    99%   199->202, 401->430, 484->496
--------------------------------------------------------------------------
TOTAL                           9240      0   2016      9    99%

Nice! Thanks @lealre for the help here. :)

[Kludex]

Thanks for the help here @lealre 🙏

[Kludex]

Ups... I think it's not finished yet 👀

[lealre]

Glad I could help here 👍

Ups... I think it's not finished yet 👀

Was it not possible to set branch=True because coverage fails in Python versions earlier than 3.9, or is it something else?

[Kludex]

Yes. 😔

[Kludex]

This issue is only on 3.9 now. Do you know why?

[Kludex]

• It's related to this Wrong coverage in for loop because the loop didn't complete nedbat/coveragepy#1175

[Kludex]

Let's change the scripts/test to only run --branch on higher than Python 3.10, and remove this custom logic when we drop 3.9.