Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebased version of fix/22 #129

Closed
wants to merge 3 commits into from
Closed

Rebased version of fix/22 #129

wants to merge 3 commits into from

Conversation

logankaser
Copy link

No description provided.

* group together fixtures for backend testing

* Add per-backend setup to allow slow initialization.
  This is specially important as kafka subscribe can return while the consumer
  is not ready. See related test setup upstream:
    - https://github.com/aio-libs/aiokafka/blob/2c54e10c57760f779961a8c2f5df8ad609ef6983/tests/test_consumer.py#L433
    - https://github.com/aio-libs/aiokafka/blob/2c54e10c57760f779961a8c2f5df8ad609ef6983/tests/_testutil.py#L376
    - https://github.com/aio-libs/aiokafka/blob/2c54e10c57760f779961a8c2f5df8ad609ef6983/tests/_testutil.py#L364

fixes #42
Signed-off-by: Pablo Woolvett <pablowoolvett@gmail.com>
This fix adds an asyncio.Lock to avoid
`asyncpg.exceptions._base.InterfaceError: cannot perform operation: another operation is in progress`

fixes #22
@logankaser
Copy link
Author

https://github.com/permitio/broadcaster/blob/master/broadcaster/_backends/postgres.py
Takes this a step further and uses a pool + some hardening

@logankaser
Copy link
Author

Going to make a version based on permitio's closing this

@logankaser logankaser closed this Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants