Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Ignored device topics" is too imprecise #36

Open
dogtopus opened this issue Feb 3, 2021 · 1 comment
Open

"Ignored device topics" is too imprecise #36

dogtopus opened this issue Feb 3, 2021 · 1 comment

Comments

@dogtopus
Copy link

dogtopus commented Feb 3, 2021

  • An empty string between commas (e.g. topic1,,topic2) blacklists all topics, causing the plugin to ignore everything it saw.
  • Generic stuff (e.g. t) massively blacklist topics that it likely shouldn't block (e.g. tele/*, tasmota/*, etc.)

My suggesstion would be switching to fnmatch or regexp against the full topic names instead of just doing naive prefix matching.
@altserg
Copy link
Contributor

altserg commented Dec 16, 2021

Pull requests are welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dogtopus @altserg