-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
# fix http headers, header could has same name key, but diff value. #39
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
approved these changes
Dec 6, 2023
emilk
approved these changes
Dec 6, 2023
tmtbe
force-pushed
the
master
branch
2 times, most recently
from
December 7, 2023 01:52
5b8d958
to
299bc28
Compare
tmtbe
force-pushed
the
master
branch
2 times, most recently
from
December 8, 2023 01:25
29c88d6
to
e1da30b
Compare
emilk
reviewed
Dec 13, 2023
Comment on lines
+29
to
+36
/// Get `Header` list from request with the given key. | ||
pub fn get_header(&self, key: String) -> Vec<String> { | ||
self.headers | ||
.iter() | ||
.filter(|h| h.0 == key) | ||
.map(|h| h.1.clone()) | ||
.collect() | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could return Vec<&str>
or impl Iterator<Item = &str>
.
The key
should be &str
Also header_values
is a better name (rust API:s don't use the get_
prefix for getters).
Suggested change
/// Get `Header` list from request with the given key. | |
pub fn get_header(&self, key: String) -> Vec<String> { | |
self.headers | |
.iter() | |
.filter(|h| h.0 == key) | |
.map(|h| h.1.clone()) | |
.collect() | |
} | |
/// Get `Header` list from request with the given key. | |
pub fn header_values(&self, key: &str) -> impl Iterator<Item = &str> { | |
self.headers | |
.iter() | |
.filter(|(name, _)| name == key) | |
.map(|(_, value)| value.as_str()) | |
} | |
/// Get the first matching header value for the given key. | |
pub fn header_value(&self, key: &str) -> Option<&str> { | |
self.header_values(key).next() | |
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http header could has same name key, but diff value.