I added a multipart feature #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
approved these changes
Sep 17, 2023
emilk
reviewed
Sep 17, 2023
I added an example to request::multipart. The multipart builder already had some documentation, but is also used in the example |
|
Should I add the method setter? |
emilk
requested changes
Sep 27, 2023
|
This pr doesn't seem to have changed in a long time. |
emilk
reviewed
Dec 13, 2023
emilk
requested changes
Dec 28, 2023
ehttp/src/multipart.rs
Outdated
Comment on lines
119
to
129
| fn write_boundary(&mut self) -> io::Result<()> { | ||
| if self.data_written { | ||
| self.inner.write_all(b"\r\n")?; | ||
| } | ||
|
|
||
| write!( | ||
| self.inner, | ||
| "-----------------------------{}\r\n", | ||
| self.boundary | ||
| ) | ||
| } |
There was a problem hiding this comment.
Writing to a Vec<u8> can never fail, so no need to return a Result here.
Instead you can either unwrap() the write!s in here, or use self.inner.extend_from_slice(b"\r\n") etc
ehttp/src/multipart.rs
Outdated
| name: &str, | ||
| filename: Option<&str>, | ||
| content_type: Option<Mime>, | ||
| ) -> io::Result<()> { |
There was a problem hiding this comment.
Same here - there should be no need for Result
ehttp/src/multipart.rs
Outdated
| /// * content_type http header content type | ||
| /// * post_data ureq.req.send_send_bytes(&post_data) | ||
| /// | ||
| pub fn finish(mut self) -> io::Result<(String, Vec<u8>)> { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its basically just ureq_multipart, but without the converion to ureqs Request so it will work with wasm.