Skip to content

Color picker button not working #5832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
lucasmerlin opened this issue Mar 20, 2025 · 0 comments
Open

Color picker button not working #5832

lucasmerlin opened this issue Mar 20, 2025 · 0 comments
Labels
bug Something is broken

Comments

@lucasmerlin
Copy link
Collaborator

Describe the bug
#5814 made it so you need to call keep_popup_open or the popup will close. Since the color picker doesn't use the new popup yet, it now immideately closes.

To Reproduce
Steps to reproduce the behavior:

  1. try using color picker on egui.rs

To fix this we should ensure all places using the Memory::popup api are either

  • updated to use the new Popup struct
  • updated to call keep_popup_open
@lucasmerlin lucasmerlin added the bug Something is broken label Mar 20, 2025
@emilk emilk added this to egui Mar 25, 2025
@emilk emilk moved this to Next up in egui Mar 25, 2025
@lucasmerlin lucasmerlin mentioned this issue Mar 25, 2025
Merged
1 task
lucasmerlin added a commit that referenced this issue Mar 25, 2025
@lucasmerlin
Fix color picker button (#5847)
884be34 
* related to #5832 
(I want to keep that open and actually update the button to use the new
popup, but this should be enough to fix it for now)
* [X] I have followed the instructions in the PR template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something is broken
Projects
egui
Status: Next up
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lucasmerlin