Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update /sponsor image #1359

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Update /sponsor image #1359

merged 2 commits into from
Feb 5, 2024

Conversation

joenash
Copy link
Contributor

@joenash joenash commented Feb 5, 2024

This PR updates the image displayed at https://emfcamp.org/sponsor to a more recent one. The previous one was the sign from (I believe) 2014, this one is from 2022.

Questions:

  • I'm removing the original image from the repo, is there any reason to keep the old one?
  • This image was sourced from the Hero Photos album, and is by Kari Bellamy. The previous photo had no attribution on the page, should this one?

@Jonty
Copy link
Member

Jonty commented Feb 5, 2024

  1. No, that's what git history is for!
  2. I don't think so, but we could add it to be nice?

@SamLR
Copy link
Member

SamLR commented Feb 5, 2024

Please add attribution, I believe it's a request of all photos from the heros directory

@russss
Copy link
Member

russss commented Feb 5, 2024

We need to design a way to show attribution, then. Which is probably best done in a separate PR.

For what it's worth, all the photos currently shown on the website (and those on archive.org with the emf_reuse_permission metadata attribute) have allowed use by us without attribution.

@Jonty
Copy link
Member

Jonty commented Feb 5, 2024

I would just add the attribution as an title tag to the image for now, as we are about to send this to a lot of sponsors imminently - and as russ said, we don't actually need to do this. But we should, because we're nice.

@joenash
Copy link
Contributor Author

joenash commented Feb 5, 2024

Cool, I've gone with the title attribute as Jonty suggests for now. Happy to modify this if a more visible solution for image attribution gets added to the site

@Jonty Jonty self-requested a review February 5, 2024 15:59
@Jonty Jonty merged commit 73e8208 into emfcamp:main Feb 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants