Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PATCH API to set video URLs on proposals #1325

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

lukegb
Copy link
Contributor

@lukegb lukegb commented Jan 23, 2024

Fixes #1306.

VIDEO_API_KEY needs to be set to something in the config.

@lukegb lukegb requested a review from wlcx January 23, 2024 20:17
@lukegb
Copy link
Contributor Author

lukegb commented Jan 23, 2024

I debated with myself about whether we should be able to set the "will be recorded" bit as well but I didn't do that in the end. Maybe we should be allowed to do that?

@wlcx
Copy link
Member

wlcx commented Jan 23, 2024

Ehh, I think we (voc) should be being told that rather than setting it

@wlcx
Copy link
Member

wlcx commented Jan 23, 2024

Whether or not we should be able to set it as individual users is another thing

@lukegb
Copy link
Contributor Author

lukegb commented Jan 23, 2024

Ehh, I think we (voc) should be being told that rather than setting it

This was mostly for late-breaking stuff (I suspect only people not wanting to be recorded where previously they'd said they would) but I think it's easier to just do this some other way and fix it later.

@wlcx
Copy link
Member

wlcx commented Jan 23, 2024 via email

@russss
Copy link
Member

russss commented Jan 23, 2024

There's already an interface for the herald or whoever's managing the stage to change this flag (along with other fun things) so you shouldn't need to worry about it.

@wlcx
Copy link
Member

wlcx commented Jan 23, 2024

@russss 👍

@russss russss enabled auto-merge (rebase) January 23, 2024 20:33
@russss russss merged commit f0b02a8 into emfcamp:main Jan 23, 2024
2 checks passed
@lukegb lukegb deleted the video-api-1306 branch January 23, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Video API
3 participants