-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PATCH API to set video URLs on proposals #1325
Conversation
I debated with myself about whether we should be able to set the "will be recorded" bit as well but I didn't do that in the end. Maybe we should be allowed to do that? |
Ehh, I think we (voc) should be being told that rather than setting it |
Whether or not we should be able to set it as individual users is another thing |
This was mostly for late-breaking stuff (I suspect only people not wanting to be recorded where previously they'd said they would) but I think it's easier to just do this some other way and fix it later. |
Eh, I’m open. Wonder if anyone else has any strong feelings?
…On Tue, 23 Jan 2024 at 20:23, Luke Granger-Brown ***@***.***> wrote:
Ehh, I think we (voc) should be being told that rather than setting it
This was mostly for late-breaking stuff (I suspect only people *not*
wanting to be recorded where previously they'd said they would) but I think
it's easier to just do this some other way and fix it later.
—
Reply to this email directly, view it on GitHub
<#1325 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXMMJKMMWQYTWGNOA7AXYLYQAL4NAVCNFSM6AAAAABCHTSJFSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBWHA3DAMRXGE>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
There's already an interface for the herald or whoever's managing the stage to change this flag (along with other fun things) so you shouldn't need to worry about it. |
@russss 👍 |
Fixes #1306.
VIDEO_API_KEY needs to be set to something in the config.