From 25ac41cc3fb92ac6106f44b9deadb8de93d886a0 Mon Sep 17 00:00:00 2001
From: Russ Garrett <russ@garrett.co.uk>
Date: Wed, 7 Feb 2024 13:27:40 +0000
Subject: [PATCH] Add some inline guidance for proposal checking and
 anonymisation

---
 apps/cfp_review/base.py                         |  2 +-
 templates/cfp_review/anonymise_list.html        |  3 ++-
 templates/cfp_review/anonymise_proposal.html    | 17 +++++++++++++++--
 .../{update_proposal.html => proposal.html}     | 12 ++++++++++++
 4 files changed, 30 insertions(+), 4 deletions(-)
 rename templates/cfp_review/{update_proposal.html => proposal.html} (95%)

diff --git a/apps/cfp_review/base.py b/apps/cfp_review/base.py
index fea2cc526..771ae2fe2 100644
--- a/apps/cfp_review/base.py
+++ b/apps/cfp_review/base.py
@@ -442,7 +442,7 @@ def log_and_close(msg, next_page, proposal_id=None):
         form.slide_link.data = prop.slide_link
 
     return render_template(
-        "cfp_review/update_proposal.html", proposal=prop, form=form, next_id=next_id
+        "cfp_review/proposal.html", proposal=prop, form=form, next_id=next_id
     )
 
 
diff --git a/templates/cfp_review/anonymise_list.html b/templates/cfp_review/anonymise_list.html
index b7d45d781..15f5b5edc 100644
--- a/templates/cfp_review/anonymise_list.html
+++ b/templates/cfp_review/anonymise_list.html
@@ -1,6 +1,7 @@
 {% extends "cfp_review/base.html" %}
+{% block title %}Proposals to Anonymise{% endblock %}
 {% block body %}
-<h2>Proposals to Anonymise<small>(showing {{ proposals | count }})</small></h2>
+<h2>Proposals to Anonymise <small>(showing {{ proposals | count }})</small></h2>
 
 <table class="table">
     <tr>
diff --git a/templates/cfp_review/anonymise_proposal.html b/templates/cfp_review/anonymise_proposal.html
index addd59167..c5681299f 100644
--- a/templates/cfp_review/anonymise_proposal.html
+++ b/templates/cfp_review/anonymise_proposal.html
@@ -1,8 +1,21 @@
 {% from "_formhelpers.html" import render_dl_field %}
 
 {% extends "cfp_review/base.html" %}
+{% block title %}Anonymise Proposal{% endblock %}
 {% block body %}
-
+<h2>Anonymise Proposal</h2>
+<div class="well">
+    <p>Please remove any detail from this proposal which would identify the submitter.</p>
+    <p>Anonymisation doesn't have to be perfect - if a reviewer knows the topic and the submitter well, they can recuse themselves - 
+        but it should be good enough that someone with a passing knowledge of the topic can't identify the submitter.
+    </p>
+    <p>If you're unable to reasonably anonymise this proposal, press "I cannot anonymise this proposal"
+        and we'll get back to the submitter and work with them to revise it.
+    </p>
+    <p>Please don't worry about the content of the proposal. Our reviewers are great - if it's not something we'd
+        want at EMF, it won't pass review.
+    </p>
+</div>
 <form method="post" action="{{ url_for('.anonymise_proposal', proposal_id=proposal.id) }}" class="shrink">
 {{ form.hidden_tag() }}
     <div class="col-md-8">
@@ -21,7 +34,7 @@ <h2>{{proposal.title}} <small>by {{proposal.user.name}}</small></h2>
     <div class="col-md-4 col-xs-12 btn-group-vertical" role="group">
         <div>&nbsp;</div>
         <div>&nbsp;</div>
-        {{ form.anonymise(class_="btn btn-success debounce", tabindex=3) }}
+        {{ form.anonymise(class_="btn btn-primary debounce", tabindex=3) }}
         {{ form.reject(class_="btn btn-danger debounce", tabindex=4) }}
         {% if next_proposal %}
             <a href="{{ url_for('.anonymise_proposal', proposal_id=next_proposal.id) }}"
diff --git a/templates/cfp_review/update_proposal.html b/templates/cfp_review/proposal.html
similarity index 95%
rename from templates/cfp_review/update_proposal.html
rename to templates/cfp_review/proposal.html
index 49a6e2ab7..3e490b9f3 100644
--- a/templates/cfp_review/update_proposal.html
+++ b/templates/cfp_review/proposal.html
@@ -6,6 +6,18 @@
 {% set active='details' %}
 {% include "cfp_review/_propsal_tabs.html" %}
 
+
+{% if proposal.state == 'new' %}
+<div class="well">
+    <p>You have the ability to mark this proposal as checked, which will send it to anonymisation. Please do so, but only if:</p>
+    <ul>
+        <li>You have knowledge of the list of banned speakers and can confirm the submitter is not banned from speaking.</li>
+        <li>The description is not obviously incomplete.</li>
+        <li>The description is superficially valid for the category it is submitted in.</li>
+    </ul>
+</div>
+{% endif %}
+
 <div class="col-md-12">
     <h2>{{proposal.published_title or proposal.title}}<br>
         <small>