Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update test_tool_caller.py #177

Closed
wants to merge 1 commit into from

Conversation

eltociear
Copy link
Contributor

breif -> brief

@kichanyurd
Copy link
Contributor

@eltociear thanks for being our first contributor!

FYI we're working on our Contributor License Agreement at the moment and expect to have it ready in 1-2 weeks.

Instead of fixing this typo ourselves while we wait for the CLA, I'd like to honor your PR by leaving it open for a little while until the CLA is ready, so that your name could be on our contributor's list—and first one at that! :)

I'll update you here soon.

@kichanyurd
Copy link
Contributor

@eltociear we're ready to accept your contribution! Also we don't require a CLA being signed. You just need to sign off your commit to comply with the DCO.

Please rebase the changes onto the latest develop branch and see if it still applies.

Thanks for your patience!

@eltociear eltociear changed the base branch from main to develop January 22, 2025 02:35
@kichanyurd
Copy link
Contributor

@eltociear Really sorry about the delay here, I can't tell you how much we've waited to merge this (first ever external) PR! 😄

Could you please fix the conflicts here and update? We'll merge it soon after.

@yannemcie
Copy link
Contributor

Hey @eltociear ,
I wanted to see if you got @kichanyurd last message? We'd love to have you resolve this so we can merge it :)
And we'd love to have you join our discord channel as well!

@kichanyurd kichanyurd closed this Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants