throw an error if anyone sets skipBabel #2247
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
NullVoxPopuli
approved these changes
Feb 2, 2025
SergeAstapov
approved these changes
Feb 2, 2025
| @@ -107,6 +107,11 @@ export type CoreOptionsType = Required< | |||
| Pick<Options, 'staticHelpers' | 'staticModifiers' | 'staticComponents' | 'staticInvokables'>; | |||
|
|
|||
| export function optionsWithDefaults(options?: Options): CoreOptionsType { | |||
| if ((options as any)?.skipBabel) { | |||
There was a problem hiding this comment.
Just theoretically possible someone make skipBabel: false and this won’t detect the case so maybe could be
Suggested change
| if ((options as any)?.skipBabel) { | |
| if (‘skipBabel’ in (options as any) || {}) { |
There was a problem hiding this comment.
oh that's nice thanks! Although this PR isn't ready because I was expecting CI to error because we have some places where this is being set 🙈
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #2207
This PR adds an error whenever someone still has the
skipBabelconfig set. This setting has already been removed in #2102 and this error is just informing people that they should remove the setting since it no longer does anything.